Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Julia and RecursiveArrayTools compat, remove NamedArrayPartition #159

Merged
merged 9 commits into from
Jan 5, 2024

Conversation

jlchan
Copy link
Owner

@jlchan jlchan commented Jan 4, 2024

RecursiveArrayTools 3.4 has NamedArrayPartition included. This PR allows v3.4 and removes NamedArrayPartition from StartUpDG. It also requires bumping Julia compat to 1.10

@jlchan jlchan changed the title Bump RecursiveArrayTools compat, remove NamedArrayPartition Bump Julia and RecursiveArrayTools compat, remove NamedArrayPartition Jan 4, 2024
@jlchan jlchan mentioned this pull request Jan 4, 2024
6 tasks
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abd0414) 96.81% compared to head (039cdd0) 96.81%.
Report is 4 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #159   +/-   ##
=======================================
  Coverage   96.81%   96.81%           
=======================================
  Files          26       25    -1     
  Lines        3325     3265   -60     
=======================================
- Hits         3219     3161   -58     
+ Misses        106      104    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlchan jlchan changed the base branch from main to dev January 5, 2024 21:11
@jlchan jlchan merged commit 8ace8fe into dev Jan 5, 2024
10 checks passed
@jlchan jlchan mentioned this pull request Jan 5, 2024
jlchan added a commit that referenced this pull request May 22, 2024
* Make triangle and tet node orderings consistent (#153)

* simplifying test

* fixing vertex orderings

* splitting wedge-pyr MeshData tests out

* fix triangulate tests

* fix wedge mesh ordering

* updating hardcoded values in VTK tests

* update tests

* bump compat for NodesAndModes to 1

* Bump Julia and RecursiveArrayTools compat, remove NamedArrayPartition  (#159)

* remove NamedArrayPartition files

d

* bump compat

* add sparsearrays compat entry

tests seem to be failing on CI without it?

* bump Julia compat

* bump julia CI version

* set lower compat bound for SummationByPartsOperators

* bump doc Julia version

* reexporting NamedArrayPartition

* Refactor `RefElemData` (#157)

* add comments

* comments and slight refactor

* comments and renaming Gauss -> TensorProductGaussCollocation

* update docstrings

* fix comment grammar

* remove unnecessary specialization

* removing outdated comments

* minor reorganization

* removing unnecessary functions

* reorganizing helper functions

* minor comment cleanup

* comments for Kubatko SBP

* comments

* introduce MultidimensionalQuadrature dispatch type

* fix hybrid mesh RefElemData

* fix tests

* simplify SBP RefElemData

* update invalidations

* improve comments

* more descriptive error message

for RefElemData constructors combining Tri/Tet/Wedge/Pyr with TensorProductQuadrature. This should be easy to implement in the future (Stroud)

* Add new cut cell `MeshData`  (#165)

* add some temporary test files

* fix docstrings

* remove cruft

* update plot

made nicer plot of Caratheodory pruning for Christina's proposal

* update file name

Makes it mroe clear this file is meant for plotting

* fixing cut cell demo for v1.0+

* adding Caratheodory pruning

* cleaning up cutcell demo

* improve efficiency slightly

* refactoring functions

* improve comments

* more refactoring

* generalize map_to_interval

* add new version of "generate_sampling_points"

* add dispatch to preserve old version of MeshData

* remove cruft

* add new routines to create a cut cell MeshData with positive weights

* refactoring

* fix construction of cut cell face node indices

previously assumed same number of nodes on all faces

* fix precomputation of operators

* clean up test of SBP property

* add test of SBP property using new MeshData

* add MomentFitting dispatch for old cut cell MeshData

d

* remove outdated todo

* changing wJf to wf internally

* add face node index array

* make face centroid computation more compact

* specialize connect_mesh

* add new MeshData based on subtriangulations

* add Subtriangulation() as a quadrature type

d

* add quadrature type to CutCellMesh meshtype

* test both Subtriangulation and MomentFitting

* add some docs

* allow specifying the target cut cell quadrature degree via keyword arg

* committing scratch testing files before deleting

d

* removing some scratch test files

* add tests for the weak SBP property

* fix an error when num_cartesian_cells = 0

* remove scratchpad files

* Adding hybridized SBP operators (#166)

* move old MomentFitting cut cell code into separate file

* fix default target_degree for volume quadrature

* formatting and modifying default parameters for cut interpolation nodes

* setting default boundary quadrature + renaming variables for clarity

* code cleanup

* storing cut_face_node_indices_by_elem_per_face

* adding hybridized SBP operators on cut cells

* adding cut cell hybridized SBP tests

* update test tolerances

* update hybridized SBP test tolerance

* Improve efficiency of cut-cell `MeshData` (#167)

* diagm -> Diagonal

* use views

* preallocate sorting permutation vector p

* improve efficiency of caratheodory

* remove type instability for PhysicalFrame basis

* bump compat for PathIntersections - should be more type stable

* fix compat for PathIntersections

* add docstring

* release <= 3.4 compat bound on RecursiveArrayTools

* add some NEWS.md updates

* remove SimpleUnpack and usages of @unpack

* Remove Requires.jl (#169)

* remove Requires statements in SummationByPartsOperators.jl ext

* remove requires statements in StartUpDG.jl

* add Plots extension

* remove unnecessary [extras] section (since we have test/Project.toml)

* remove unnecessary compat restriction on SummationByPartsOperators.jl

* add TriangulatePlotExt

* remove Requires.jl

* add to NEWS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant